Skip to content

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Mar 15, 2023

Description

Updated condition for getting/adding kubectl apply synced timeline.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local Environment
  • Microk8s cluster

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nishant-d nishant-d merged commit a4222a9 into main Mar 15, 2023
@nishant-d nishant-d deleted the pipeline-status-fix branch March 15, 2023 08:02
@kartik-579
Copy link
Member Author

RCA: we were updating health status pipeline on basis of reconciliation time and kubectl apply synced timeline. In an edge case, if the sync status changes from succeeded to something else, kubectl apply synced timeline was not getting fetched and this was causing health timeline to not update whereas deployment status was getting updated since we had extra call for kubectl applly synced timeline there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants