fix:showing right image imagetags in multiplecolons in registry url #3103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
prakash100198
approved these changes
Mar 10, 2023
rish2320
deleted the
showing-right-image-imagetags-in-multiplecolons-in-registry-url
branch
kartik-579
pushed a commit
that referenced
this pull request
Mar 28, 2023
…3103) * main-test-for-docker-image * main-test-for-docker-image * main-test-for-docker-image * main-test-for-docker-image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a custom docker registry (with a custom port) and deploying an application, the deployed pod fails with ImagePullBackOff. Looking at the gitops repo, the generated values of the image name and tag are incorrect. I am using Nexus as the docker repo and devtron v0.6.10.
Fixes #2845
How Has This Been Tested?
1: To start with I created multiple apps with single colon in registry url and inspected the image value and tags .
2: Moving Forward I created a nexus private repository to test with multiple colons .
3: We got to know the CI-runner was producing the image right but during deployment the image was getting broken .
4: Furthermore I followed the API triggered and to the point where image was getting broken and fixed it at the backend .
5: Finally after fixing it tested it again and the image and image tags were produced right this time in yaml file .
Checklist:
Does this PR introduce a user-facing change?