Skip to content

fix: getting all environmets for super admin only #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2023
Merged

fix: getting all environmets for super admin only #3096

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2afa11
added batch enforcing on environments
gireesh-naidu Mar 9, 2023
d72d5ee
checking for super admin access only.
gireesh-naidu Mar 9, 2023
58e6071
error logging
gireesh-naidu Mar 9, 2023
f49a90a
enforcing in batch
gireesh-naidu Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions api/cluster/EnvironmentRestHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,24 +148,40 @@ func (impl EnvironmentRestHandlerImpl) Get(w http.ResponseWriter, r *http.Reques
}

func (impl EnvironmentRestHandlerImpl) GetAll(w http.ResponseWriter, r *http.Request) {
bean, err := impl.environmentClusterMappingsService.GetAll()
environments, err := impl.environmentClusterMappingsService.GetAll()
if err != nil {
impl.logger.Errorw("service err, GetAll", "err", err)
common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
return
}

var result []request.EnvironmentBean
token := r.Header.Get("token")
for _, item := range bean {
// RBAC enforcer applying
if ok := impl.enforcer.Enforce(token, casbin.ResourceGlobalEnvironment, casbin.ActionGet, strings.ToLower(item.EnvironmentIdentifier)); ok {
result = append(result, item)
emailId, err := impl.userService.GetEmailFromToken(token)
if err != nil {
impl.logger.Errorw("error in getting emailId from token", "err", err, "token", token)
common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
return
}

grantedEnvironments := make([]*request.EnvironmentBean, 0)

var envIdentifierList []string
envIdentifierMap := make(map[string]*request.EnvironmentBean)
for _, item := range environments {
envIdentifier := strings.ToLower(item.EnvironmentIdentifier)
envIdentifierList = append(envIdentifierList, envIdentifier)
envIdentifierMap[envIdentifier] = &item
}

// RBAC enforcer applying
rbacResultMap := impl.enforcer.EnforceByEmailInBatch(emailId, casbin.ResourceGlobalEnvironment, casbin.ActionGet, envIdentifierList)
for envIdentifier, item := range envIdentifierMap {
if rbacResultMap[envIdentifier] {
grantedEnvironments = append(grantedEnvironments, item)
}
//RBAC enforcer Ends
}

common.WriteJsonResp(w, err, result, http.StatusOK)
common.WriteJsonResp(w, err, grantedEnvironments, http.StatusOK)
}

func (impl EnvironmentRestHandlerImpl) GetAllActive(w http.ResponseWriter, r *http.Request) {
Expand Down