Skip to content

Conversation

@adi6859
Copy link
Contributor

@adi6859 adi6859 commented Mar 6, 2023

Description

This feature will show notes.txt file on helm apps that id deployed via gitops.

Fixes AB2880

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
1.I have done testing this via image deployment on vm.
2. I have checked for all cases that is for showing notes.txt file.Below are all the test case :-
a. show notes for chart with templated notes.
b.show notes for chart with Plaintext notes.
c. show notes for chart that is not containing notes.
All behaviour is working fine.
3.I have also tested via UI by deploying all types of helm chart here also behaviour is as expected.
4. I have also done testing by applying multiple breakpoint for checking data is coming or not.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@adi6859 adi6859 merged commit 34db77e into main Mar 7, 2023
@adi6859 adi6859 deleted the notes-support-for-gitops branch March 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Show NOTES.txt for helm apps deployed through Devtron with gitops

4 participants