Skip to content

Conversation

@prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Mar 5, 2023

Description

Currently we don’t review configuration changes before deploying any image after building an image, currently we only support reviewing config changes when we do rollbacks on the basis of 3 parameters, 1. Last saved config. 2. Last deployed config , and 3. Config deployed with selected image. But we want to have the same kind of feature when we click on Select Image -> Deploy, but there the review of config will only be on the basis of two parameters, i.e 1. Last saved config. 2. Last deployed config.
Design for the same is shown in the below screenshots for reference:-
image
image

fixes #2024

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test case A :- 1. Created a workflow with one cd and tested the code working fine in that case. 2. Created multiple workflow with multiple combinations of cd pipelines configured, one cd after another cd and with parallel cd also, code working fine in that case too. 2. Tested the comparison of config in case of Select Image -> compare diff between last saved and last deployed, working in that case too. 4. Tested a corner case when there is no last deployed image, there will not be any diff shown, user can only review the last saved config in that case and deploy via only last saved config.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikramdevtron vikramdevtron self-requested a review March 16, 2023 12:56
@prakash100198 prakash100198 merged commit 65fd4ba into main Mar 17, 2023
@prakash100198 prakash100198 deleted the review-config-changes-before-deployment branch March 17, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants