Skip to content

fix: pod resources not visible even if user have access on those pods. #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: pod resources not visible even if user have access on those pods. #3071

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a21e4e4
test commit
gireesh-naidu Mar 2, 2023
aec6b1b
test-commit 2
gireesh-naidu Mar 2, 2023
291819c
test-commit 3
gireesh-naidu Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion util/k8s/k8sApplicationService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,13 +670,15 @@ func (impl *K8sApplicationServiceImpl) GetResourceList(ctx context.Context, toke
return resourceList, err
}
k8sRequest := request.K8sRequest
//store the copy of requested resource identifier
resourceIdentifierCloned := k8sRequest.ResourceIdentifier
resp, namespaced, err := impl.k8sClientService.GetResourceList(ctx, restConfig, k8sRequest)
if err != nil {
impl.logger.Errorw("error in getting resource list", "err", err, "request", request)
return resourceList, err
}
checkForResourceCallback := func(namespace, group, kind, resourceName string) bool {
resourceIdentifier := k8sRequest.ResourceIdentifier
resourceIdentifier := resourceIdentifierCloned
Copy link
Contributor

@pghildiyal pghildiyal Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can start with empty installation

resourceIdentifier.Name = resourceName
resourceIdentifier.Namespace = namespace
if group != "" && kind != "" {
Copy link
Contributor

@pghildiyal pghildiyal Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this check

Expand Down