fix: logs file path issue fix and docker file update for non root user #3024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added non root user support in Dockerfile * minor change for dockerfileEA --------- Co-authored-by: Rupin Solanki <[email protected]> Co-authored-by: Rupin Solanki <[email protected]>
…rfile-nonrootuser
gireesh-naidu
changed the title
gireesh-naidu
changed the title
util/helper.go
Outdated
| } | ||
|
|
||
| type BaseLogLocationConfig struct { | ||
| BaseLogLocationPath string `env:"BASE_LOG_LOCATION_PATH" envDefault:"home/devtron/"` |
There was a problem hiding this comment.
put this in ciConfig and cdConfig and read it from there.
|
Kudos, SonarCloud Quality Gate passed!
|
kripanshdevtron
approved these changes
Mar 2, 2023
|
Dockerfile changes are also reviewed |
rupinSec
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
made logs base file path configurable.
Fixes https://dev.azure.com/DevtronLabs/Devtron/_workitems/edit/2174/
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?