Skip to content

feat: add api to change deployment app type for all cd pipelines in an environment #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Feb 22, 2023
Merged

feat: add api to change deployment app type for all cd pipelines in an environment #2975

merged 39 commits into from
Feb 22, 2023

Conversation

@vishal-dt
Copy link
Contributor

@vishal-dt vishal-dt commented Feb 16, 2023 •
edited
Loading

Description

With this PR, an API is being introduced to change the deployment type for all cd pipelines in an environment.

Fixes

#2972

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@vishal-dt
add api to force delete all cd pipelines of all apps of an environmen…
97de5f3 
…t from argo cd
@vishal-dt
update deployment_app_type to helm and toggle deployment_app_created …
cdd6e08 
…to false in db when changing cd app type and refactored
@vishal-dt
remove code smell
7019279
@vishal-dt
add check on app health status before deleting app from argocd
bd904c0
@vishal-dt
resolve build issues
647fab2
@vishal-dt
Revert "resolve build issues"
47db893 
This reverts commit 647fab2.
@vishal-dt
revert and resolve build issues: missing argocd assets
22b85ad
@vishal-dt
add support for changing deployment type from helm to argo_cd
36aee78
@vishal-dt
resolve sonar issue: decrease cognitive complexity
ae27ffb
@vishal-dt
resolve sonar issue: decrease cognitive complexity
6757f0b
@vishal-dt
resolve sonar issue: decrease cognitive complexity
88cdfc9
@vishal-dt
resolve sonar issue: decrease cognitive complexity
4d9cba3
@vishal-dt
resolve sonar issue: decrease cognitive complexity
346661b
@vishal-dt
resolve sonar issue: decrease cognitive complexity
f8c4c24
@vishal-dt
Merge branch 'main' of https://github.com/devtron-labs/devtron into f…
024e55f 
…eat-deployment-app-type-change-api
@vishal-dt vishal-dt marked this pull request as ready for review February 16, 2023 11:08
vishal-dt and others added 12 commits February 21, 2023 13:34
@vishal-dt
add auto-deploy property in request
4c37937
@vishal-dt
fix: panic while getting artifacts for cd pipelines for which parent …
1094085 
…cd not triggered
@vishal-dt
fix: pg panic when empty slice is passed as arg
b2a70b3
@vishal-dt @kripanshdevtron @kartik-579
Feat deployment change (#3017)
4e6e987 
* include apps handling

* fix for nil error panic (#18)

* chart latest handling added

* query syntax fix

---------

Co-authored-by: Kripansh <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
@vishal-dt
Merge branch 'main' of https://github.com/devtron-labs/devtron into …
2864b45 
…feat-deployment-app-type-change-api
@vishal-dt
sync changes from devtron ea
f49e010
@vishal-dt
minor fixes
0136a1c
@vishal-dt
update api spec
41311dc
@vishal-dt
fix: bug ignoring deployment trigger
cb063f6
@vishal-dt
disable auto-trigger property
dfc0f5a
@vishal-dt
Merge branch 'main' of https://github.com/devtron-labs/devtron into f…
4c67c41 
…eat-deployment-app-type-change-api
@vishal-dt
replace concatenation with query params in pg query
c05d0c8
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

@vishal-dt vishal-dt merged commit 853d0a1 into main Feb 22, 2023
@vishal-dt vishal-dt deleted the feat-deployment-app-type-change-api branch February 22, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anupdhiran anupdhiran Awaiting requested review from anupdhiran

1 more reviewer

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishal-dt @kripanshdevtron