Skip to content

feat: show notes txt for helmapps deployed by helm #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2023
Merged

feat: show notes txt for helmapps deployed by helm #2966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a03e6af
added notes field in installed app details
adi6859 Feb 13, 2023
25c9026
Merge branch 'main' into show-notes-txt-helmapps-gitops-helm
adi6859 Feb 15, 2023
dee782b
added omitempty field in installed app details
adi6859 Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/bean/AppView.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ type AppDetailContainer struct {
Environments []Environment `json:"otherEnvironment,omitempty"`
LinkOuts []LinkOuts `json:"linkOuts,omitempty"`
ResourceTree map[string]interface{} `json:"resourceTree,omitempty"`
Notes string `json:"notes,omitempty"`
}

type Environment struct {
Expand Down
1 change: 1 addition & 0 deletions pkg/appStore/deployment/service/InstalledAppService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,7 @@ func (impl InstalledAppServiceImpl) FetchResourceTree(rctx context.Context, cn h
resourceTree := util3.InterfaceToMapAdapter(detail.ResourceTreeResponse)
resourceTree["status"] = detail.ApplicationStatus
appDetail.ResourceTree = resourceTree
appDetail.Notes = detail.ChartMetadata.Notes
impl.logger.Warnw("appName and envName not found - avoiding resource tree call", "app", appDetail.AppName, "env", appDetail.EnvironmentName)
} else {
appDetail.ResourceTree = map[string]interface{}{}
Expand Down