Skip to content

fix: issue resolved for notification on deployment trigger and telemetry summary event #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2023
Merged

fix: issue resolved for notification on deployment trigger and telemetry summary event #2893

merged 2 commits into from
Jan 24, 2023

Conversation

@vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Jan 24, 2023 •
edited
Loading

Description

  • Notification issues on deployment pipeline trigger for Linked Ci Pipelines. fix added.
  • Telemetry summary event posted to posthog got issues when no helm apps fetched for clusters. fix added.

Fixes # https://dev.azure.com/DevtronLabs/Devtron/_workitems/edit/1825

How Has This Been Tested?

  • Slack notification for linked Ci Pipeline
  • Telemetry summary event

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@vikramdevtron vikramdevtron self-assigned this Jan 24, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikramdevtron vikramdevtron merged commit 0d582b9 into main Jan 24, 2023
@vikramdevtron vikramdevtron deleted the hotfix-AB1812 branch January 24, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vikramdevtron vikramdevtron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vikramdevtron @kripanshdevtron