Skip to content

fix: helm manifest output in deployment history #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2023
Merged

fix: helm manifest output in deployment history #2822

merged 6 commits into from
Jan 24, 2023

Conversation

@iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Jan 4, 2023 •
edited
Loading

Description

This PR fixes two issues:-

  1. helm generated manifest output was not coming for helm apps other than unlinked cli helm apps.
  2. Deployment history was coming for app store helm apps. It was only coming after app is updated.

Fixes #2823

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  1. By checking that helm generated manifest output is coming for all helm apps or not.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@iamayushm iamayushm changed the title Fix: helm manifest output in deployment history fix: helm manifest output in deployment history Jan 4, 2023
@iamayushm
Merge branch 'main' into fix_helm_manifest_output_in_deployment_history
cba2de6
@iamayushm
fix: deployment history not coming for first time
304e7e3
@iamayushm
adding cluster check
7cb208a
@iamayushm
Merge branch 'main' into fix_helm_manifest_output_in_deployment_history
5afe1a1 
# Conflicts:
#	api/helm-app/HelmAppService.go
#	cmd/external-app/wire_gen.go
#	pkg/appStore/bean/bean.go
#	pkg/appStore/deployment/tool/gitops/AppStoreDeploymentArgoCdService.go
#	wire_gen.go
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikramdevtron vikramdevtron merged commit d416d3e into main Jan 24, 2023
@vikramdevtron vikramdevtron deleted the fix_helm_manifest_output_in_deployment_history branch January 24, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: helm manifest output in deployment history

3 participants

@iamayushm @vikramdevtron