Skip to content

feat: Resource viewer implementation for a cluster #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 99 commits into from
Jan 6, 2023
Merged

feat: Resource viewer implementation for a cluster #2811

merged 99 commits into from
Jan 6, 2023

Conversation

@kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Dec 31, 2022 •
edited by manish-agrawal-ai
Loading

Description

APIs and implementation for Resource Browser and RBAC implementation for those APIs.

Fixes #2813

How Has This Been Tested?

  • Resource browser actions (view, create, list)
  • RBAC/Authorisation

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

manish-agrawal-ai and others added 30 commits December 29, 2022 18:48
@manish-agrawal-ai
API for getApiResources for a cluster
49ca2bf
@manish-agrawal-ai
update resource api
9b8e6cf
@manish-agrawal-ai
resource delete API change
26ff223
@kripanshdevtron
native k8s support added for APIs
3a20b8c
@vikramdevtron
gkv resource list api spec added
8aed4a8
@vikramdevtron
added gkv resource list api
c19e59f
@vikramdevtron
resource list request dto modified
54a78ac
@kartik-579
added script
0048883
@kripanshdevtron
namespaces api for cluster
2074eef
@vikramdevtron
status added for resource list
4ec57f3
@vikramdevtron
Merge branch 'resource_browser' of https://github.com/devtron-labs/de…
b7bd085 
…vtron into resource_browser
@manish-agrawal-ai
create resources API
409b622
@manish-agrawal-ai
bug fix in get api-resources API
ddd1c09
@vikramdevtron
events list api modified, for all gkv or by namespace
43a3521
@vikramdevtron
Merge branch 'resource_browser' of https://github.com/devtron-labs/de…
efeef39 
…vtron into resource_browser
@manish-agrawal-ai
bug fixes
602906c
@kartik-579
added cluster rbac for roleGroup
06768c5
@manish-agrawal-ai
createResources changed to applyResources
51b8461
@kartik-579
updated cluster entity for create/update user apis
e0615b0
@kripanshdevtron
api refactored
d32c2be
@kartik-579
extracted code for checking cluster entity rbac
9a2a533
@kartik-579
added casbin sql script for superadmin cluster entity policies
e277377
@kartik-579
updated spec
0560f2c
@kripanshdevtron
Merge branch 'cluster-rbac' into resource_browser
3365eb7
@manish-agrawal-ai
applyResource change to createOrUpdate
5b96ba3
@vikramdevtron
review changes and event list for all gkv fixed
9ab657b
@vikramdevtron
conflicts resolved with apply resource
2ed1686
@vikramdevtron
containers list added in resource list api
88579be
@vikramdevtron
auth for resource list api
515e675
@vikramdevtron
global kind event check added for event listing
67da071
@manish-agrawal-ai manish-agrawal-ai changed the title Feat: Resource viewer implementation for a cluster feat: Resource viewer implementation for a cluster Jan 4, 2023
kripanshdevtron and others added 16 commits January 4, 2023 17:43
@kripanshdevtron
resource name fix for groups
b88ab1e
@vikramdevtron
group roles checked for namespace and cluster list api
0553699
@vikramdevtron
added one more item star if has access to all namespaces
45e0933
@manish-agrawal-ai
refactoring
6c893c6
@kripanshdevtron
manager auth RBAC handling
ce71772
@kripanshdevtron
Merge branch 'resource_browser' of https://github.com/devtron-labs/de…
55ec8a7 
…vtron into resource_browser
@kripanshdevtron
multi resource validation handling
30ae68b
@manish-agrawal-ai
all namespace data reverted
c4d29a8
@manish-agrawal-ai
RBAC in getApiResources API
d80f7b6
@manish-agrawal-ai
RBAC fix in ApplyResource for namespace
a4f7ccd
@manish-agrawal-ai
bug fixes :
5d2609c 
1) if cluster list is empty for non super admin user, then sending 403
@manish-agrawal-ai
bug fixes :
1574a1a 
1) sending 403 if empty api-resources
@manish-agrawal-ai
fix: all group with particular kind handling
456f6de
@kripanshdevtron @manish-agrawal-ai
Resource browser rbac (#2836)
094d3b8 
* RBAC hierarchy check added

* hiererachy handlign for workload APIs

* gvk fix

* app group name fix

* switch case correction

Co-authored-by: Manish Agrawal <[email protected]>
@manish-agrawal-ai
Revert "Resource browser rbac (#2836)" (#2838)
c4dcff1 
This reverts commit 094d3b8.
@manish-agrawal-ai
Merge branch 'main' into resource_browser
8d45568
@manish-agrawal-ai manish-agrawal-ai merged commit 34c948d into main Jan 6, 2023
@manish-agrawal-ai manish-agrawal-ai deleted the resource_browser branch January 6, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartik-579 kartik-579 Awaiting requested review from kartik-579

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

1 more reviewer

@manish-agrawal-ai manish-agrawal-ai manish-agrawal-ai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Resource viewer for a cluster

5 participants

@kripanshdevtron @manish-agrawal-ai @vikramdevtron @kartik-579