Skip to content

fix: cluster name passed in node metadata list #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2022
Merged

fix: cluster name passed in node metadata list #2804

merged 2 commits into from
Dec 28, 2022

Conversation

@kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Dec 28, 2022

Description

This change includes clusterName passed in node metadata list.

Fixes #2803

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@kripanshdevtron kripanshdevtron self-assigned this Dec 28, 2022
@kripanshdevtron kripanshdevtron added the bug Something isn't working label Dec 28, 2022
@kripanshdevtron kripanshdevtron removed their assignment Dec 28, 2022
@kripanshdevtron kripanshdevtron changed the title cluster name passed in node metadata list fix: cluster name passed in node metadata list Dec 28, 2022
@kripanshdevtron kripanshdevtron merged commit 860e9e3 into main Dec 28, 2022
@kripanshdevtron kripanshdevtron deleted the cluster-name-metadata branch December 28, 2022 10:15
@kripanshdevtron kripanshdevtron self-assigned this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@manish-agrawal-ai manish-agrawal-ai manish-agrawal-ai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kripanshdevtron kripanshdevtron

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: cluster terminal fails to open | Intermittent

3 participants

@kripanshdevtron @manish-agrawal-ai