fix: chart repository fixes #2730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| } | ||
|
|
||
| token := r.Header.Get("token") |
There was a problem hiding this comment.
why do we need to move logic here ??
| } | ||
|
|
||
| func (impl *ChartRepositoryServiceImpl) UpdateChartRepo(request *ChartRepoDto) (*chartRepoRepository.ChartRepo, error) { | ||
| func (impl *ChartRepositoryServiceImpl) UpdateChartRepo(request *ChartRepoDto, chartRepoId int) (*chartRepoRepository.ChartRepo, error) { |
There was a problem hiding this comment.
why do we need chartRepoId ??
| Deleted bool `sql:"deleted,notnull"` | ||
| sql.AuditLog | ||
| } | ||
| type ChartRepoWithDeploymentCount struct { |
There was a problem hiding this comment.
use composition here
gireesh-naidu
changed the title
gireesh-naidu
changed the title
|
SonarCloud Quality Gate failed.
|
kripanshdevtron
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocked update and delete chart repository if any helm app is deployed with this chart
Fixes #1306
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: