Skip to content

fix: removed required validation for deployment template #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022
Merged

fix: removed required validation for deployment template #2713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/appbean/AppDetail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ type DeploymentTemplate struct {
ShowAppMetrics bool `json:"showAppMetrics"`
IsOverride bool `json:"isOverride"`
IsBasicViewLocked bool `json:"isBasicViewLocked"`
CurrentViewEditor models.ChartsViewEditorType `json:"currentViewEditor" validate:"required"`
CurrentViewEditor models.ChartsViewEditorType `json:"currentViewEditor"` //default "UNDEFINED" in db
}

type AppWorkflow struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/chart/ChartService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ type TemplateRequest struct {
Schema json.RawMessage `json:"schema"`
Readme string `json:"readme"`
IsBasicViewLocked bool `json:"isBasicViewLocked"`
CurrentViewEditor models.ChartsViewEditorType `json:"currentViewEditor" validate:"required"`
CurrentViewEditor models.ChartsViewEditorType `json:"currentViewEditor"` //default "UNDEFINED" in db
UserId int32 `json:"-"`
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/pipeline/PropertiesConfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ type EnvironmentProperties struct {
ChartRefId int `json:"chartRefId,omitempty" validate:"number"`
IsOverride bool `sql:"isOverride"`
IsBasicViewLocked bool `json:"isBasicViewLocked"`
CurrentViewEditor models.ChartsViewEditorType `json:"currentViewEditor" validate:"required"`
CurrentViewEditor models.ChartsViewEditorType `json:"currentViewEditor"` //default "UNDEFINED" in db
}

type EnvironmentPropertiesResponse struct {
Expand Down