Skip to content

fix: migration down sql for 84 #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: migration down sql for 84 #2706

merged 1 commit into from
Nov 30, 2022

Conversation

@pawan-mehta-dt
Copy link
Contributor

Description

fix: migration down sql for 84
it fails if we rollback

How Has This Been Tested?

  • Tested with a rollback

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@nishant-d nishant-d merged commit df3d6ed into main Nov 30, 2022
@nishant-d nishant-d deleted the fix-down-sql branch November 30, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nishant-d nishant-d nishant-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawan-mehta-dt @nishant-d