Skip to content

Conversation

@vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Nov 29, 2022

Description

Load argo cd setting after acd module installation, while creating new argocd token.

Partial Fix : impossible configure GitOps, Bad Gateway #2511

How Has This Been Tested?

  • Deployed devtron base in new cluster, and install cicd
  • Install argo-cd integration with some missing data on argocd-secret.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@vikramdevtron vikramdevtron self-assigned this Nov 29, 2022
@vikramdevtron vikramdevtron linked an issue Dec 1, 2022 that may be closed by this pull request
2 tasks
@vikramdevtron vikramdevtron changed the title Fix: cd setting manager reload Fix: ArgoCD Connection Manager connection handling Dec 2, 2022
@vikramdevtron vikramdevtron changed the title Fix: ArgoCD Connection Manager connection handling fix: ArgoCD Connection Manager connection handling Dec 7, 2022
@gitguardian
Copy link

gitguardian bot commented Dec 16, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret 354f28d scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/env-values.yaml View secret
2763127 Generic High Entropy Secret 354f28d scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

kartik-579
kartik-579 previously approved these changes Dec 16, 2022
nishant-d
nishant-d previously approved these changes Dec 16, 2022
@vikramdevtron vikramdevtron dismissed stale reviews from nishant-d and kartik-579 via d24e112 December 16, 2022 13:38
@vikramdevtron vikramdevtron merged commit 34335bd into main Dec 19, 2022
@vikramdevtron vikramdevtron deleted the cd-setting-manager-reload branch December 19, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants