Skip to content

Conversation

@gireesh-naidu
Copy link
Contributor

@gireesh-naidu gireesh-naidu commented Nov 28, 2022

Description

External links can now be configured at cluster level and app level.
Fixes #1991

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested for Create,update,put and post operations for applevel and clusterlevel links.
  • Tested above operations for all the user roles.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@gireesh-naidu gireesh-naidu merged commit 7d3bdc8 into main Nov 28, 2022
@gireesh-naidu gireesh-naidu deleted the external_links_script_fix branch November 28, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External links should support configurable links for each app

3 participants