Skip to content

feat: Support of reuse container image in containers section in reference chart 4-17 #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2023
Merged

feat: Support of reuse container image in containers section in reference chart 4-17 #2675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87a443c
support of reuse conatiner image in containers section
Nov 23, 2022
24fd2b3
Merge branch 'main' of https://github.com/devtron-labs/devtron into c…
Jan 31, 2023
6dbc578
support of reuse container image in latest deployment and rollout chart
Jan 31, 2023
b28ec48
added the readme
Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion docs/user-guide/creating-application/deployment-template/rollout-deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ It contains the commands to run inside the container.
| `workingDir` | It is used to specify the working directory where commands will be executed. |

### Containers
Containers section can be used to run side-car containers along with your main container within same pod. Containers running within same pod can share volumes and IP Address and can address each other @localhost.
Containers section can be used to run side-car containers along with your main container within same pod. Containers running within same pod can share volumes and IP Address and can address each other @localhost. We can use base image inside container by setting the reuseContainerImage flag to `true`.

```yaml
containers:
Expand All @@ -519,6 +519,19 @@ Containers section can be used to run side-car containers along with your main c
- containerPort: 80
command: ["/usr/local/bin/nginx"]
args: ["-g", "daemon off;"]
- reuseContainerImage: true
securityContext:
runAsUser: 1000
runAsGroup: 3000
fsGroup: 2000
volumeMounts:
- mountPath: /etc/ls-oms
name: ls-oms-cm-vol
command:
- flyway
- -configFiles=/etc/ls-oms/flyway.conf
- migrate

```

### Prometheus
Expand Down
14 changes: 13 additions & 1 deletion scripts/devtron-reference-helm-charts/deployment-chart_1-1-0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ It contains the commands for the server.


### Containers
Containers section can be used to run side-car containers along with your main container within same pod. Containers running within same pod can share volumes and IP Address and can address each other @localhost.
Containers section can be used to run side-car containers along with your main container within same pod. Containers running within same pod can share volumes and IP Address and can address each other @localhost. We can use base image inside container by setting the reuseContainerImage flag to `true`.

```yaml
containers:
Expand All @@ -573,6 +573,18 @@ Containers section can be used to run side-car containers along with your main c
- containerPort: 80
command: ["/usr/local/bin/nginx"]
args: ["-g", "daemon off;"]
- reuseContainerImage: true
securityContext:
runAsUser: 1000
runAsGroup: 3000
fsGroup: 2000
volumeMounts:
- mountPath: /etc/ls-oms
name: ls-oms-cm-vol
command:
- flyway
- -configFiles=/etc/ls-oms/flyway.conf
- migrate
```

### Prometheus
Expand Down
27 changes: 26 additions & 1 deletion scripts/devtron-reference-helm-charts/deployment-chart_1-1-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,32 @@ spec:
mountPath: /etc/envoy-config/
{{- end}}
{{- if $.Values.containers }}
{{ toYaml $.Values.containers | indent 8 -}}
{{- range $i, $c := .Values.containers }}
{{- if .reuseContainerImage}}
- name: {{ $.Chart.Name }}-sidecontainer-{{ add1 $i }}
image: "{{ $.Values.server.deployment.image }}:{{ $.Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if .securityContext }}
securityContext:
{{ toYaml .securityContext | indent 12 }}
{{- end }}
{{- if .command}}
command:
{{ toYaml .command | indent 12 -}}
{{- end}}
{{- if .resources}}
resources:
{{ toYaml .resources | indent 12 -}}
{{- end}}
{{- if .volumeMounts}}
volumeMounts:
{{ toYaml .volumeMounts | indent 12 -}}
{{- end}}
{{- else}}
-
{{ toYaml . | indent 10 }}
{{- end}}
{{- end}}
{{- end}}
- name: {{ $.Chart.Name }}
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
Expand Down
14 changes: 13 additions & 1 deletion scripts/devtron-reference-helm-charts/reference-chart_4-17-0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ It contains the commands for the server.


### Containers
Containers section can be used to run side-car containers along with your main container within same pod. Containers running within same pod can share volumes and IP Address and can address each other @localhost.
Containers section can be used to run side-car containers along with your main container within same pod. Containers running within same pod can share volumes and IP Address and can address each other @localhost. We can use base image inside container by setting the reuseContainerImage flag to `true`.

```yaml
containers:
Expand All @@ -501,6 +501,18 @@ Containers section can be used to run side-car containers along with your main c
- containerPort: 80
command: ["/usr/local/bin/nginx"]
args: ["-g", "daemon off;"]
- reuseContainerImage: true
securityContext:
runAsUser: 1000
runAsGroup: 3000
fsGroup: 2000
volumeMounts:
- mountPath: /etc/ls-oms
name: ls-oms-cm-vol
command:
- flyway
- -configFiles=/etc/ls-oms/flyway.conf
- migrate
```

### Prometheus
Expand Down
27 changes: 26 additions & 1 deletion scripts/devtron-reference-helm-charts/reference-chart_4-17-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,32 @@ spec:
mountPath: /etc/envoy-config/
{{- end}}
{{- if $.Values.containers }}
{{ toYaml $.Values.containers | indent 8 -}}
{{- range $i, $c := .Values.containers }}
{{- if .reuseContainerImage}}
- name: {{ $.Chart.Name }}-sidecontainer-{{ add1 $i }}
image: "{{ $.Values.server.deployment.image }}:{{ $.Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if .securityContext }}
securityContext:
{{ toYaml .securityContext | indent 12 }}
{{- end }}
{{- if .command}}
command:
{{ toYaml .command | indent 12 -}}
{{- end}}
{{- if .resources}}
resources:
{{ toYaml .resources | indent 12 -}}
{{- end}}
{{- if .volumeMounts}}
volumeMounts:
{{ toYaml .volumeMounts | indent 12 -}}
{{- end}}
{{- else}}
-
{{ toYaml . | indent 10 }}
{{- end}}
{{- end}}
{{- end}}
- name: {{ $.Chart.Name }}
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
Expand Down