Skip to content

fix: added creation of ecr repo for ci template override checkpoints #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2022
Merged

fix: added creation of ecr repo for ci template override checkpoints #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78114f4
fix for creating ecr repo
kartik-579 Nov 23, 2022
e2cf81f
refactored code
kartik-579 Nov 23, 2022
e7e048f
updated service name
kartik-579 Nov 23, 2022
8e98fcb
renamed method name
kartik-579 Nov 23, 2022
47cd38f
updated repo creation call
kartik-579 Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Wire.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ func InitializeApp() (*App, error) {
wire.Bind(new(pipeline2.PipelineConfigRestHandler), new(*pipeline2.PipelineConfigRestHandlerImpl)),
router.NewPipelineRouterImpl,
wire.Bind(new(router.PipelineConfigRouter), new(*router.PipelineConfigRouterImpl)),
pipeline.NewDbPipelineOrchestrator,
wire.Bind(new(pipeline.DbPipelineOrchestrator), new(*pipeline.DbPipelineOrchestratorImpl)),
pipeline.NewCiCdPipelineOrchestrator,
wire.Bind(new(pipeline.CiCdPipelineOrchestrator), new(*pipeline.CiCdPipelineOrchestratorImpl)),
pipelineConfig.NewMaterialRepositoryImpl,
wire.Bind(new(pipelineConfig.MaterialRepository), new(*pipelineConfig.MaterialRepositoryImpl)),

Expand Down
22 changes: 11 additions & 11 deletions pkg/appWorkflow/AppWorkflowService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ type AppWorkflowService interface {
}

type AppWorkflowServiceImpl struct {
Logger *zap.SugaredLogger
appWorkflowRepository appWorkflow.AppWorkflowRepository
dbPipelineOrchestrator pipeline.DbPipelineOrchestrator
ciPipelineRepository pipelineConfig.CiPipelineRepository
pipelineRepository pipelineConfig.PipelineRepository
Logger *zap.SugaredLogger
appWorkflowRepository appWorkflow.AppWorkflowRepository
ciCdPipelineOrchestrator pipeline.CiCdPipelineOrchestrator
ciPipelineRepository pipelineConfig.CiPipelineRepository
pipelineRepository pipelineConfig.PipelineRepository
}

type AppWorkflowDto struct {
Expand Down Expand Up @@ -87,13 +87,13 @@ type WorkflowComponentNamesDto struct {
CdPipelines []string `json:"cdPipelines"`
}

func NewAppWorkflowServiceImpl(logger *zap.SugaredLogger, appWorkflowRepository appWorkflow.AppWorkflowRepository, dbPipelineOrchestrator pipeline.DbPipelineOrchestrator, ciPipelineRepository pipelineConfig.CiPipelineRepository, pipelineRepository pipelineConfig.PipelineRepository) *AppWorkflowServiceImpl {
func NewAppWorkflowServiceImpl(logger *zap.SugaredLogger, appWorkflowRepository appWorkflow.AppWorkflowRepository, ciCdPipelineOrchestrator pipeline.CiCdPipelineOrchestrator, ciPipelineRepository pipelineConfig.CiPipelineRepository, pipelineRepository pipelineConfig.PipelineRepository) *AppWorkflowServiceImpl {
return &AppWorkflowServiceImpl{
Logger: logger,
appWorkflowRepository: appWorkflowRepository,
dbPipelineOrchestrator: dbPipelineOrchestrator,
ciPipelineRepository: ciPipelineRepository,
pipelineRepository: pipelineRepository,
Logger: logger,
appWorkflowRepository: appWorkflowRepository,
ciCdPipelineOrchestrator: ciCdPipelineOrchestrator,
ciPipelineRepository: ciPipelineRepository,
pipelineRepository: pipelineRepository,
}
}

Expand Down
Loading