Skip to content

fix: Lifecycle hook failing due to default values #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 22, 2022
Merged

fix: Lifecycle hook failing due to default values #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3bdb4f0
Updated version in README.md
pawan-mehta-dt Nov 22, 2022
4e40c29
Updated chart version
pawan-mehta-dt Nov 22, 2022
2659d99
Updated default values
pawan-mehta-dt Nov 22, 2022
55dd720
Added chart 4.16 for lifecycle fix
Nov 22, 2022
ce8ecb1
Added migrations for chart 4.16
Nov 22, 2022
e1a102b
Updated down sql for 4.16
Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/devtron-reference-helm-charts/reference-chart_4-15-0/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
name: reference-chart_4-14-0
version: 4.14.0
name: reference-chart_4-15-0
version: 4.15.0
4 changes: 2 additions & 2 deletions scripts/devtron-reference-helm-charts/reference-chart_4-15-0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

# Rollout Deployment Chart - v4.11
# Rollout Deployment Chart - v4.15

## 1. Yaml File -

Expand Down Expand Up @@ -624,4 +624,4 @@ resources.limits.cpu >= resources.requests.cpu
resources.limits.memory >= resources.requests.memory
envoyproxy.resources.limits.cpu >= envoyproxy.resources.requests.cpu
envoyproxy.resources.limits.memory >= envoyproxy.resources.requests.memory
```
```
16 changes: 8 additions & 8 deletions scripts/devtron-reference-helm-charts/reference-chart_4-15-0/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,14 +415,14 @@ envoyproxy:
containerSpec:
lifecycle:
enabled: false
preStop:
exec:
command: ["sleep","10"]
postStart:
httpGet:
host: example.com
path: /example
port: 90
preStop: {}
# exec:
# command: ["sleep","10"]
postStart: {}
# httpGet:
# host: example.com
# path: /example
# port: 90

podDisruptionBudget: {}
# minAvailable: 1
Expand Down
22 changes: 22 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-16-0/.helmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Patterns to ignore when building packages.
# This supports shell glob matching, relative path matching, and
# negation (prefixed with !). Only one pattern per line.
.DS_Store
# Common VCS dirs
.git/
.gitignore
.bzr/
.bzrignore
.hg/
.hgignore
.svn/
# Common backup files
*.swp
*.bak
*.tmp
*~
# Various IDEs
.project
.idea/
*.tmproj
.vscode/
1 change: 1 addition & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-16-0/.image_descriptor_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"server":{"deployment":{"image_tag":"{{.Tag}}","image":"{{.Name}}"}},"pipelineName": "{{.PipelineName}}","releaseVersion":"{{.ReleaseVersion}}","deploymentType": "{{.DeploymentType}}", "app": "{{.App}}", "env": "{{.Env}}", "appMetrics": {{.AppMetrics}}}
5 changes: 5 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-16-0/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
name: reference-chart_4-16-0
version: 4.16.0
Loading