Skip to content

Docker checkout path Fix #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2022
Merged

Docker checkout path Fix #2616

merged 2 commits into from
Nov 11, 2022

Conversation

@kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Nov 11, 2022 •
edited
Loading

Description

Dockerfile checkout path was not working for earlier created apps. Checkout path was getting appended twice to actual dockerfile path

Fixes #2617

How Has This Been Tested?

  • Apps whose checkout path is present in old structure
  • Apps created with checkout path is working fine

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@kripanshdevtron kripanshdevtron added the bug Something isn't working label Nov 11, 2022
@kripanshdevtron kripanshdevtron self-assigned this Nov 11, 2022
@kripanshdevtron kripanshdevtron marked this pull request as ready for review November 11, 2022 08:30
@kripanshdevtron kripanshdevtron merged commit c78da31 into main Nov 11, 2022
@kripanshdevtron kripanshdevtron deleted the docker-checkoutpath-fix branch November 11, 2022 08:39
pghildiyal
pghildiyal reviewed Nov 12, 2022
View reviewed changes
pkg/pipeline/CiService.go
templateOverride := templateOverrideBean.CiTemplateOverride
checkoutPath = templateOverride.GitMaterial.CheckoutPath
dockerfilePath = filepath.Join(checkoutPath, templateOverride.DockerfilePath)
dockerfilePath = templateOverride.DockerfilePath
Copy link
Contributor

@pghildiyal pghildiyal Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should name be absoluteDockerfilePath ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pghildiyal pghildiyal pghildiyal left review comments

@nishant-d nishant-d nishant-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kripanshdevtron kripanshdevtron

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Project Checkout Feature not working for old Apps

4 participants

@kripanshdevtron @nishant-d @pghildiyal