docs: Image Pull Secret Doc #2604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pghildiyal
reviewed
Nov 17, 2022
| Provide a name to your registry and this name will be shown to you in Build Configuration in the drop-down list. | ||
|
|
||
| ### Registry type | ||
| ### Registry Type |
There was a problem hiding this comment.
This is a common "Registry Type", it was defined again in detail. It's confusing so I have removed it as it is already mentioned in the table while adding container registry. Now, I have included clickable link for each registry type to keep the navigation easier.
pghildiyal
reviewed
Nov 17, 2022
| # Container Registries | ||
|
|
||
| Container registries are used to store images built by the CI Pipeline. Here you can configure the container registry you want to use for storing images. | ||
| Container registries are used for storing images built by the CI Pipeline. You can configure the container registry using any different cloud provider of your choice. It allows you to build, deploy and manage your container images with easy-to-use UI. |
There was a problem hiding this comment.
its not cloud provide its container registry provider of your choice
prakarsh-dt
reviewed
Nov 17, 2022
| # Container Registries | ||
|
|
||
| Container registries are used to store images built by the CI Pipeline. Here you can configure the container registry you want to use for storing images. | ||
| Container registries are used for storing images built by the CI Pipeline. You can configure the container registry using any different container registry provider of your choice. It allows you to build, deploy and manage your container images with easy-to-use UI. |
There was a problem hiding this comment.
using any different sounds repetitive.
There was a problem hiding this comment.
Removed "different".
prakarsh-dt
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description