Ci Build config API backward compatibilty #2598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manish-agrawal-ai
approved these changes
Nov 9, 2022
pawan-59
added a commit
that referenced
this pull request
Nov 9, 2022
* fixed migration query in 90th migration (#2586) * updated wiring for TelemetryEventClientExtended.go (#2588) * feat: Provide description for Chart Types (#2585) * chart description provided with the api call * added code to provide chart description with the api call * refined the code for poviding chart description * mitigated nil pointer exception in ChartService * refactoring * changes in sql files Co-authored-by: Manish Agrawal <[email protected]> * sql script semicolon fix (#2590) * Ci Build config API backward compatibilty (#2598) * docker build config added as backward compatible changes * dependency injection fix Co-authored-by: kartik-579 <[email protected]> Co-authored-by: Prakash Kumar <[email protected]> Co-authored-by: Manish Agrawal <[email protected]> Co-authored-by: kripanshdevtron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently we have modified Ci Build Config in which we have added support for Buildpack and managed docker file feature, which impacted app creation API, so dockerBuildConfig param is still existing for backward compatibilty.
Fixes #2561
How Has This Been Tested?
Checklist:
Does this PR introduce a user-facing change?