Skip to content

Conversation

@manish-agrawal-ai
Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai commented Nov 3, 2022

Description

If devtron is installed with cicd then cicd module status should go in installing.

Fixes #2571

How Has This Been Tested?

  1. cicd module should be installable from UI if devtron is installed without cicd. and its status should be updated to installed if installed successfully.
  2. cicd module should be shown as installing if devtron is installed with cicd and user logged in dashboard before installation completes. and after sometime the status should change to installed when installation finishes.
  3. cicd module should be shown as installed if user logged into dashboard after installation completes.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@manish-agrawal-ai manish-agrawal-ai changed the title Issue 2571 fix fix: cicd module status as installing if devtron is installing with cicd module Nov 3, 2022
@manish-agrawal-ai manish-agrawal-ai changed the title fix: cicd module status as installing if devtron is installing with cicd module fix: showing cicd module status as installing if devtron is installing with cicd module Nov 3, 2022
@manish-agrawal-ai manish-agrawal-ai requested review from kripanshdevtron and removed request for vikramdevtron November 3, 2022 10:17
@manish-agrawal-ai manish-agrawal-ai merged commit 6421edd into main Nov 3, 2022
@manish-agrawal-ai manish-agrawal-ai deleted the issue_2571_fix branch November 3, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throwing error if quickly login into dashboard before completion of the CICD installation

3 participants