Skip to content

Conversation

@manish-agrawal-ai
Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai commented Oct 29, 2022

Description

Auto inject Image pull secret while deploying devtron-app if access given for cluster for that docker registry
Fixes #1930

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Testcases list

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@manish-agrawal-ai manish-agrawal-ai changed the title Issue 1930 feat : Auto inject Image pull secret while deploying devtron-app Oct 29, 2022
vikramdevtron
vikramdevtron previously approved these changes Nov 4, 2022
@vikramdevtron vikramdevtron self-requested a review November 11, 2022 04:28
vikramdevtron
vikramdevtron previously approved these changes Nov 11, 2022
@manish-agrawal-ai manish-agrawal-ai merged commit a3d1187 into main Nov 11, 2022
@manish-agrawal-ai manish-agrawal-ai deleted the issue_1930 branch November 11, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to pull image with 401 Unauthorized when deployed to AKS + Azure Container Registry

3 participants