Skip to content

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Oct 12, 2022

Description

Api for fetching all notification recipients and fetching all permission groups did not have rbac. Added rbac to them. Fixed rbac for notification channel listing api.

Fixes #2518

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local Environment
  • Testing environment

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@kartik-579 kartik-579 self-assigned this Oct 12, 2022
@kartik-579 kartik-579 changed the title fix: added rbac for notification recipient listing api fix: updated rbac for notification and permission group apis Oct 21, 2022
@kartik-579 kartik-579 merged commit 39e8f75 into main Oct 21, 2022
@kartik-579 kartik-579 deleted the preview-changes branch October 21, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Rbac for notification, channels & permission group listing do not work as expected

3 participants