Skip to content

Conversation

@vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Sep 9, 2022

Description

Dex changes - configuration moves from argocd config map to devtron secret

Fixes # (issue): #2330

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • SSO login with new configuration
  • SSO login with existing configuration migration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@vikramdevtron vikramdevtron self-assigned this Sep 9, 2022
@vikramdevtron vikramdevtron linked an issue Sep 9, 2022 that may be closed by this pull request
@vikramdevtron vikramdevtron linked an issue Sep 9, 2022 that may be closed by this pull request
nishant-d
nishant-d previously approved these changes Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dex changes - configuration moves from argocd to devtron Store Dex config in a secret

3 participants