Skip to content

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Sep 8, 2022

Description

ESO secrets were showing overriden even when they are not. Fixed data fetch call for env level secrets.

Fixes #2255

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test case A
  • Test case B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@kartik-579 kartik-579 linked an issue Sep 10, 2022 that may be closed by this pull request
2 tasks
@milindk8 milindk8 merged commit 23a8f36 into main Sep 10, 2022
@milindk8 milindk8 deleted the secret-change branch September 10, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete Override is not showing for external secret

4 participants