Skip to content

Conversation

@kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Sep 3, 2022

Description

made auth config driven using a flag. user can set flag through config map, when flag is set auth is bypassed for autocomplete APIs of projects and environments.

Fixes #2283

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • To check whether flag is enabled or not, can check in logs

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@kripanshdevtron kripanshdevtron marked this pull request as ready for review September 3, 2022 09:28
@kripanshdevtron kripanshdevtron self-assigned this Sep 3, 2022
@kripanshdevtron kripanshdevtron added the enhancement New feature or request label Sep 3, 2022
@nishant-d nishant-d merged commit b397ffc into main Sep 3, 2022
@nishant-d nishant-d deleted the autocomplete-data-connfig-driven branch September 3, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make auth check configurable for Team/Env autocomplete APIs

3 participants