Skip to content

Hotfix : panic handling casbin loads fails #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

Hotfix : panic handling casbin loads fails #1992

merged 1 commit into from
Jul 8, 2022

Conversation

@vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Jul 8, 2022 •
edited
Loading

Description

Handle Panic on casbin enforcer and casbin remove and add policy loads failed operation.

Fixes # (issue): #1678

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • User update operation with multiple permissions

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@vikramdevtron vikramdevtron self-assigned this Jul 8, 2022
@vikramdevtron vikramdevtron linked an issue Jul 8, 2022 that may be closed by this pull request
Updating multiple access for a user results in Unauthorized for everyone for few minutees #1678
Closed
2 tasks
@vikramdevtron vikramdevtron requested a review from pghildiyal July 8, 2022 13:52
@pghildiyal pghildiyal merged commit 83e3403 into main Jul 8, 2022
@pghildiyal pghildiyal deleted the hotfix-1678 branch July 8, 2022 17:49
kamal-devtron added a commit that referenced this pull request Oct 23, 2024
@kamal-devtron
Charts hotfix (#1992)
b25dd3c 
* Synced all chart changes

* Updated VPA in sts chart

* chnages in sts SM
prakarsh-dt pushed a commit that referenced this pull request Oct 23, 2024
@kamal-devtron
Charts hotfix (#1992) (#6018)
dc012c0 
* Synced all chart changes

* Updated VPA in sts chart

* chnages in sts SM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pghildiyal pghildiyal pghildiyal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vikramdevtron vikramdevtron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating multiple access for a user results in Unauthorized for everyone for few minutees

3 participants

@vikramdevtron @pghildiyal