Skip to content

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Jul 5, 2022

Description

Ci pipeline deletion throws error that cd pipeline exists when there a cd pipeline with id = ciPipelineId and has a children cd. This makes the check of having children pass even when there is none. Updated the query to check children of ci pipeline independent of other pipelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@kartik-579 kartik-579 linked an issue Jul 5, 2022 that may be closed by this pull request
2 tasks
@kartik-579 kartik-579 self-assigned this Jul 6, 2022
@nishant-d nishant-d merged commit a9c509b into main Jul 6, 2022
@nishant-d nishant-d deleted the cd-pipeline-fix branch July 6, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to delete ci-pipeline

3 participants