Skip to content

Feat: helm app status update periodically #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 21, 2022
Merged

Feat: helm app status update periodically #1896

merged 6 commits into from
Jun 21, 2022

Conversation

@vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Jun 16, 2022 •
edited
Loading

Description

Devtron apps deployed by helm, status update periodically by cron job.
Allow post cd creation on without gitops configuration case.

Fixes # (issue): #1654

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • non-gitops case, CD and Post-CD auto trigger tested.
  • app workflow, with pre-post cd.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@vikramdevtron vikramdevtron self-assigned this Jun 16, 2022
@vikramdevtron vikramdevtron linked an issue Jun 16, 2022 that may be closed by this pull request
Cd pipeline status - Helm app status update periodically #1654
Closed
@vikramdevtron vikramdevtron requested a review from nishant-d June 16, 2022 13:23
nishant-d
nishant-d suggested changes Jun 21, 2022
View reviewed changes
manish-agrawal-ai
manish-agrawal-ai approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved by nishant

@vikramdevtron vikramdevtron removed the request for review from nishant-d June 21, 2022 15:15
@vikramdevtron vikramdevtron requested a review from nishant-d June 21, 2022 15:15
@manish-agrawal-ai manish-agrawal-ai removed the request for review from nishant-d June 21, 2022 15:16
@nishant-d nishant-d merged commit c6ada75 into main Jun 21, 2022
@nishant-d nishant-d deleted the helm-app-status-update-cron-job branch June 21, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prakarsh-dt prakarsh-dt prakarsh-dt approved these changes

+2 more reviewers

@nishant-d nishant-d nishant-d approved these changes

@manish-agrawal-ai manish-agrawal-ai manish-agrawal-ai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vikramdevtron vikramdevtron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cd pipeline status - Helm app status update periodically

5 participants

@vikramdevtron @nishant-d @prakarsh-dt @manish-agrawal-ai