Skip to content

FEAT: Added workingDir parameter in reference-chart_4-xx #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2022
Merged

FEAT: Added workingDir parameter in reference-chart_4-xx #1826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26833d6
added workingDir parameter in reference-chart_4-xx
Abhinav-26 Jun 6, 2022
bc0d69d
added cconditions for the workingDir parameter
Abhinav-26 Jun 6, 2022
52112db
updated conditions for workingDir
Abhinav-26 Jun 8, 2022
c8a6c94
removed workingDir from env-values.yaml
Abhinav-26 Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-10-0/app-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ ingressInternal:
# - chart-example.local

command:
workingDir: {}
enabled: false
value: []

Expand Down
3 changes: 3 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-10-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ spec:
containerPort: {{ .port }}
protocol: TCP
{{- end}}
{{- if and $.Values.command.enabled $.Values.command.workingDir }}
workingDir: {{ $.Values.command.workingDir }}
{{- end}}
{{- if and $.Values.command.value $.Values.command.enabled}}
command:
{{ toYaml $.Values.command.value | indent 12 -}}
Expand Down
5 changes: 3 additions & 2 deletions scripts/devtron-reference-helm-charts/reference-chart_4-10-0/test_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,9 @@ dbMigrationConfig:
enabled: false

command:
enabled: false
value: []
workingDir: /app
enabled: true
value: ["ls"]

args:
enabled: false
Expand Down
1 change: 1 addition & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-11-0/app-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ ingressInternal:
# - chart-example.local

command:
workingDir: {}
enabled: false
value: []

Expand Down
3 changes: 3 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-11-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ spec:
containerPort: {{ .port }}
protocol: TCP
{{- end}}
{{- if and $.Values.command.enabled $.Values.command.workingDir }}
workingDir: {{ $.Values.command.workingDir }}
{{- end}}
{{- if and $.Values.command.value $.Values.command.enabled}}
command:
{{ toYaml $.Values.command.value | indent 12 -}}
Expand Down
5 changes: 3 additions & 2 deletions scripts/devtron-reference-helm-charts/reference-chart_4-11-0/test_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,9 @@ dbMigrationConfig:
enabled: false

command:
enabled: false
value: []
workingDir: /app
enabled: true
value: ["ls"]

args:
enabled: false
Expand Down
1 change: 1 addition & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-12-0/app-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ ingressInternal:
# - chart-example.local

command:
workingDir: {}
enabled: false
value: []

Expand Down
3 changes: 3 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-12-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ spec:
containerPort: {{ .port }}
protocol: TCP
{{- end}}
{{- if and $.Values.command.enabled $.Values.command.workingDir }}
workingDir: {{ $.Values.command.workingDir }}
{{- end}}
{{- if and $.Values.command.value $.Values.command.enabled}}
command:
{{ toYaml $.Values.command.value | indent 12 -}}
Expand Down
7 changes: 4 additions & 3 deletions scripts/devtron-reference-helm-charts/reference-chart_4-12-0/test_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ prometheusRule:


ingress:
enabled: true
enabled: false
className: nginx
annotations: {}
# nginx.ingress.kubernetes.io/rewrite-target: /
Expand Down Expand Up @@ -204,7 +204,7 @@ ingress:
# - chart-example.local

ingressInternal:
enabled: true
enabled: false
className: nginx-internal
annotations: {}
# kubernetes.io/ingress.class: nginx
Expand All @@ -231,8 +231,9 @@ dbMigrationConfig:
enabled: false

command:
workingDir: /app
enabled: false
value: []
value: ["ls"]

args:
enabled: false
Expand Down