Skip to content

Conversation

@pghildiyal
Copy link
Contributor

@pghildiyal pghildiyal commented Apr 12, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1494 and #531

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Create ECR type container registry without user name and password and run CI pipeline with security enabled. It should complete it successfully. try this again after it has been idle for 14 hrs.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@nishant-d nishant-d merged commit f6f1faf into main Apr 13, 2022
@nishant-d nishant-d deleted the ecr-role-login branch April 13, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEAT: allow ec2 role based access for ECR repo

3 participants