Skip to content

Bug: panic error if cd trigger fails #3100

@gireesh-naidu

Description

@gireesh-naidu

📜 Description

if cd trigger is failed ,then orchestrator getting restarted with panic error

👟 Reproduction steps

  1. make something to fail cd trigger
  2. observe orchestrator panicing with error
    panic: runtime error: invalid memory address or nil pointer dereference
    [Mar 09 2023 19:16:33 GMT+0530] orchestrator: [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x42c1d97]
    [Mar 09 2023 19:16:33 GMT+0530] orchestrator: goroutine 249 [running]:
    [Mar 09 2023 19:16:33 GMT+0530] orchestrator: github.com/devtron-labs/devtron/pkg/pipeline.(*WorkflowDagExecutorImpl).updatePreviousDeploymentStatus(0xc000994000, 0xc00068adc0, 0x0?, {0x5789100, 0xc001915120}, {0xc000584718?, 0xc0013078a8?, 0x76dba20?}, 0x1)

👍 Expected behavior

should not panic, the error should have been handled properly

👎 Actual Behavior

orchestrator panicing with error
panic: runtime error: invalid memory address or nil pointer dereference
[Mar 09 2023 19:16:33 GMT+0530] orchestrator[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x42c1d97]
[Mar 09 2023 19:16:33 GMT+0530] orchestrator: goroutine 249 [running]:
[Mar 09 2023 19:16:33 GMT+0530] orchestrator: github.com/devtron-labs/devtron/pkg/pipeline.(*WorkflowDagExecutorImpl).updatePreviousDeploymentStatus(0xc000994000, 0xc00068adc0, 0x0?, {0x5789100, 0xc001915120}, {0xc000584718?, 0xc0013078a8?, 0x76dba20?}, 0x1)

☸ Kubernetes version

v1

Cloud provider

🌍 Browser

Chrome

🧱 Your Environment

No response

✅ Proposed Solution

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions