chore: port forward tls client server name #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivam-nagar23
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
nishant-d
suggested changes
Jun 17, 2025
vikramdevtron
previously approved these changes
Jun 17, 2025
Shivam-nagar23
changed the base branch from
develop
to
release-candidate-v0.38.0
Shivam-nagar23
dismissed
vikramdevtron’s stale review
The base branch was changed.
vikramdevtron
approved these changes
Jun 17, 2025
nishant-d
approved these changes
Jun 17, 2025
vikramdevtron
added a commit
that referenced
this pull request
Jun 19, 2025
* SecretFieldClusterId to CmFieldClusterId
* replace secret informer with field selector to configmap informer with label selector
* CreateConfigMapObject
* ClusterModifyEventSecretTypeKey
* DeleteConfigMap k8s util func
* correct label selector
* add extra validation in add , update and delete func
if labelValue, exists := cmObject.Labels["type"]; !exists || labelValue != informerBean.ClusterModifyEventSecretType {
return
}
* cm informer instead of secret informer for cluster
* bump common lib
* bump common lib
* bump common lib
* bump common lib
* fix
* bump common lib
* bump common lib
* r
* ClusterModifyEventCmLabelValue = "cluster-request-modify"
* ClusterModifyEventCmLabelValue = "type=cluster-request-modify"
* import label selector from commonb lib
* import label selector from commonb lib
* ClusterModifyEventCmLabelKeyValue and ClusterModifyEventCmLabelValue
* small fix
* small fix
* add logger for ignoring cluster change event in case label not found
* fix
* logger
* refactoring of CreateConfigMapObject
* fix
* bump common lib
* bump common lib
* remove WithCmName and make cmname as func signature
* code review incorporation
* bump common lib
* make
* bump common lib
* Merge pull request #282 from devtron-labs/dependa-fix
misc: Dependabot changes to fix vulnerabilities
* chore: http shutdown timeout configurable (#291) (#293)
* feat: add server shutdown timeout configuration and improve logging
* feat: add SERVER_SHUTDOWN_TIMEOUT to configuration
Co-authored-by: Shivam Nagar <[email protected]>
* restored mod changes for kubelink and kubewatch (#294)
* vendor update on rc 38 (#295)
* chore: port forward tls client server name (#296)
* chore-port-forward-debug
* review comments resolved
---------
Co-authored-by: Prakash Kumar <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: prakhar katiyar <[email protected]>
Co-authored-by: Shivam Nagar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.