feat: Cluster terminal enhancement I2 #764

milindk8 · 2023-02-15T05:28:43Z

Description

Include cluster terminal FE-only fixes & enhancement

Cluster terminal: Auto-select a node on which the terminal can be launched
Show node-groups - Add node groups column on node list Ability to search nodes by node groups
- Terminal > Node dropdown
- Categorize nodes by node groups
- Categorize ungrouped nodes in ‘Independent nodes’ category
- If no node group exists, show all nodes without any categorization
For custom images select sh as the default
Ability to provide custom shell
Messaging if the pod has been deleted
When switching shell > Show message eg. Switching shell to bash
If the selected shell is not supported, show the error message “{shellName} is not supported in the selected image”
Connection timed out handling

Fixes #(AB1893)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

By selecting the auto node option to select a node which connects automatically
With the BE help testing error cases for node connection

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR require documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas

vivek-devtron · 2023-02-23T06:20:27Z

src/components/common/helpers/Helpers.tsx

+        }
+    })
+
+    return [{label: '',options: [AUTO_SELECT]},...groupList]


Format this file

vivek-devtron · 2023-02-23T06:27:07Z

src/components/ClusterNodes/NodeList.tsx

                if (searchedTextMap.size !== matchedLabelCount) {
                    continue
                }
+            } else if (selectedSearchTextType === 'nodeGroup') {


we should create some constant for nodeGroup as it is being used on multiple places

vivek-devtron · 2023-02-23T06:50:09Z

src/components/ClusterNodes/ClusterEvents.tsx

+    terminalAccessId,
+    reconnectStart,
+}: {
+    terminalAccessId: number


Please move this to type

vivek-devtron · 2023-02-23T06:52:55Z

src/components/ClusterNodes/ClusterEvents.tsx

                    setLoading(false)
-                    const events = response.result?.events.items
+                    const events = response.result
                    setEvents(events)


we can directly set the data into setEvents no need to create the variable. also please accommodate events?.eventsResponse?.events.items it here only and and not at the time of passing the props on line no 45

vivek-devtron · 2023-02-23T06:56:50Z

src/components/ClusterNodes/ClusterTerminal.tsx

                    })
            }
-            toggleOptionChange()
+


This is supposed to be useEffect's clean up function. right? Please move it out from try catch block

no, it's not. It's just setting the state

vivek-devtron · 2023-02-23T07:23:24Z

src/components/ClusterNodes/ClusterTerminal.tsx

                                    value={selectedNodeName}
                                    onChange={onChangeNodes}
-                                    styles={clusterSelectStyle}
+                                    styles={{


move this out to const

vivek-devtron · 2023-03-02T07:40:50Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/Terminal.tsx

+    }
+
+    const renderErrorMessageStrip = (errorMessage) => {
+        if (errorMessage.message === 'timedOut') {


we should move this to const

vivek-devtron · 2023-03-02T07:41:00Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/Terminal.tsx

+                    {TERMINAL_TEXT.CASE_OF_ERROR}
+                </div>
+            )
+        } else if (errorMessage.message === 'Terminated') {


vivek-devtron · 2023-03-02T07:41:19Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/Terminal.tsx

                let sessionId = response.result.userTerminalSessionId
                let status = response.result.status
-                if (!sessionId && count) {
+                if(status === 'Running' && !response.result?.isValidShell){


we should move statuses to const

vivek-devtron · 2023-03-02T07:41:27Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/Terminal.tsx

+                if(status === 'Running' && !response.result?.isValidShell){
+                    preFetchData(status,'failed')
+                    setErrorMessage({message: response.result?.errorReason, reason: ''})
+                } else if (status === 'Terminated'){


src/components/v2/common/ReactSelect.utils.tsx

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/constants.ts

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/EventsTable.tsx

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/Terminal.tsx

src/components/ClusterNodes/clusterNodes.service.tsx

src/components/ClusterNodes/NodeListSearchFilter.tsx

src/components/ClusterNodes/NodeList.tsx

sonarqubecloud · 2023-03-03T07:58:33Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-03-06T14:52:38Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	5.14%	1542/30015
🔴	Branches	2.93%	674/22970
🔴	Functions	2.95%	266/9002
🔴	Lines	5.22%	1495/28638

Test suite run success

67 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from 93f21db

milindk8 added 5 commits February 13, 2023 17:55

Some changes

6288fb2

Fixed auto node bug

a1d7899

Added terminated state

aa05135

Fixed errorReason

3c44988

constant messaging

ff649e3

milindk8 requested review from shivani170, sohel-rp and vivek-devtron February 15, 2023 05:28

This comment has been minimized.

Sign in to view

Removed shell sh

0f0dfcd

This comment has been minimized.

Sign in to view

Minor fix

cd7b75a

This comment has been minimized.

Sign in to view

Merge branch 'main' into cluster-terminal-enhancement

6afd9ca

This comment has been minimized.

Sign in to view

Fixed race condition bug

0462ec4

This comment has been minimized.

Sign in to view

milindk8 and others added 7 commits February 17, 2023 12:57

fix polling when time out

b873d44

fix sizing in edit mode

db03eca

Placeholder changes

0bdaa4c

Fixed width issue

596d1ca

fixed socket resize issue

d73b067

format code

5cfbb38

minor review changes

2c0c2d9

vivek-devtron reviewed Feb 23, 2023

View reviewed changes

Merge branch 'main' into cluster-terminal-enhancement

1022083

vivek-devtron reviewed Mar 2, 2023

View reviewed changes

milindk8 and others added 2 commits March 2, 2023 14:29

Merge branch 'main' into cluster-terminal-enhancement

5684b26

constants added

baf4787

milindk8 requested a review from vivek-devtron March 2, 2023 09:07

Merge branch 'main' into cluster-terminal-enhancement

6560c75