Skip to content

ci workflow esacpe fixed #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 8, 2022
Merged

ci workflow esacpe fixed #569

merged 7 commits into from
Oct 8, 2022

Conversation

@shivani170
Copy link
Contributor

@shivani170 shivani170 commented Oct 8, 2022 •
edited
Loading

Description

Escape Key to close modals in Workflow editor - Devtron UI

Fixes https://dev.azure.com/DevtronLabs/Devtron/_boards/board/t/Devtron%20Team/Issues
Fix devtron-labs/devtron#2414

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Testing in CI
  • Testing in CD
  • Testing in External CI
  • Testing linked CI

@shivani170 shivani170 self-assigned this Oct 8, 2022
@shivani170 shivani170 merged commit ed0c059 into main Oct 8, 2022
@shivani170 shivani170 deleted the workflow__esc branch October 8, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vivek-devtron vivek-devtron vivek-devtron approved these changes

+1 more reviewer

@sohel-rp sohel-rp sohel-rp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shivani170 shivani170

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Escape Key to close modals in Workflow editor - Devtron U

4 participants

@shivani170 @vivek-devtron @sohel-rp