Allow users to generate API tokens with the desired access #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| close: () => void | ||
| setShowRegeneratedModal: React.Dispatch<React.SetStateAction<boolean>> | ||
| editData: EditDataType | ||
| customDate |
|
|
||
| export const getSelectedEnvironments = (permission) => { | ||
| if (permission.accessType === ACCESS_TYPE_MAP.DEVTRON_APPS) { | ||
| return permission.environment.find((env) => env.value === '*') |
Contributor
There was a problem hiding this comment.
We can change this implementation to single for loop
| action: permission.action.value, | ||
| team: permission.team.value, | ||
| environment: getSelectedEnvironments(permission), | ||
| entityName: permission.entityName.find((entity) => entity.value === '*') |
| } | ||
| } | ||
|
|
||
| interface SinglrDatePickerProps { |
| placeholder="Enter a description to remember where you have used this token" | ||
| className="form__textarea" | ||
| value={editData.description} | ||
| onChange={(e) => onChangeEditData(e, 'description')} |
Contributor
There was a problem hiding this comment.
Can add name here to remove inliune function
| /> | ||
| <div className="icon-dim-16 ml-8"> | ||
| <Clipboard | ||
| onClick={(e) => { |
Contributor
There was a problem hiding this comment.
inline function can be removed
| > | ||
| <Clipboard className="icon-dim-16" /> | ||
| Copy token | ||
| <button className="flex cta mt-20 mb-20" onClick={(e) => handleCopyToClipboard(e)}> |
Contributor
There was a problem hiding this comment.
remove inline function change it to {handleCopyToClipboard}
vivek-devtron
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to generate API tokens with the desired access:
Fixes devtron-labs/devtron#1810
Type of change
Checklist: