Skip to content

Conversation

@eshankvaish
Copy link
Contributor

@eshankvaish eshankvaish commented Feb 13, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1808

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Feb 13, 2025
@eshankvaish eshankvaish marked this pull request as draft February 13, 2025 13:31
@eshankvaish eshankvaish changed the base branch from develop to feat/info-bar February 14, 2025 06:56
Copy link
Contributor Author

@eshankvaish eshankvaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@eshankvaish eshankvaish marked this pull request as ready for review February 14, 2025 10:26
Base automatically changed from feat/info-bar to develop February 17, 2025 05:43
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Feb 17, 2025
vivek-devtron
vivek-devtron previously approved these changes Feb 18, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@eshankvaish eshankvaish merged commit d4dfa6f into develop Feb 18, 2025
8 of 9 checks passed
@eshankvaish eshankvaish deleted the feat/text-field branch February 18, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:Ready-to-Review PR:Ready-to-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants