Skip to content

Conversation

@Bulani
Copy link
Contributor

@Bulani Bulani commented Oct 28, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #2562

Link to prove your SVG is correct and up-to-date.

https://typer.tiangolo.com/
https://github.com/fastapi/typer/blob/master/docs/img/icon.svg

@Bulani
Copy link
Contributor Author

Bulani commented Oct 28, 2025

@weh Can you tag it with Hacktoberfest?

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bulani, thank you for your contribution. To use the icon for the font, it needs to be a single svg path with a single color. so in the current form it is not usable. Check our wiki pages for instructions: Creating Plain Icons

Also the current file should be named typer-original-wordmark.svg. If you find time it should be no big effort to also create a typer-original.svg and typer-plain.svg version by removing the text. This should not be a big thing, and would match most of the existing icon submissions having versions with and without wordmark.

@weh weh added the hacktoberfest Issues we want Hacktoberfest contributors to help with label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Issues we want Hacktoberfest contributors to help with

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants