-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: cursor (original, original-wordmark) #2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@canaleal @lunatic-fox @ReenigneArcher @ConX @weh Could I get a review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This icon has multiple fill colors, paths, and is not optimized so it cannot be used as a font icon.
Please create another icon with only 1 fill color and 1 path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @canaleal thanks for review. how should i create another icon with only 1 fill color and 1 path? like i tried it but the icon is getting changed due to single path
|
I don't really review icons, but I notice the PR title has extra whitespace. Should start with Once you change this, you will have to force push to the branch to get the workflow to pick up the change. |
|
Hey @canaleal, Can You Review these changes and help me with the original SVG file? |
Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereThis PR closes #2546
Link to prove your SVG is correct and up-to-date.