update icon: lua (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canaleal
added
the
feature:icon
weh
approved these changes
Nov 23, 2023
weh
requested review from
a team,
ConX,
Snailedlt and
lunatic-fox
and removed request for
a team
lunatic-fox
requested changes
Dec 1, 2023
There was a problem hiding this comment.
As @weh commented and as far as I see there are no "non-wordmark" versions for this icon.
- The
originalversion has "Lua" in#ffffff.
original
Perhaps, we should make these changes:
- Rename
original-wordmarktooriginal, deleteoriginal-wordmark. Aliasoriginalasoriginal-wordmark. - Rename
plain-wordmarktoplain, deleteplain-wordmark. Aliasplainasplain-wordmark. - Rename
line-wordmarktoline, deleteline-wordmark. Aliaslineasline-wordmark.
lunatic-fox
approved these changes
Dec 3, 2023
Snailedlt
approved these changes
Dec 3, 2023
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
… line, line-wordmark) (devicons#2033) * update icon: lua * Replaced original, plain, line with wordmark svgs * Added white fill to lua original --------- Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR is related to #1998
Link to prove your SVG is correct and up-to-date.
Additional Notes
Used the color
#000080for the font SVGs.All 3 versions were created as the Original SVGs had 2 colors; Navy for the planet/moon and gray for the orbit path.