Skip to content

Add alias and remove duplicate files #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Add alias and remove duplicate files #2001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6720021
Add alias for digitalocean
weh Nov 13, 2023
5914e21
Add alias for gatsby
weh Nov 13, 2023
e5a74f6
Add alias for mysql plain
weh Nov 13, 2023
2ed0500
Add alias for nodejs plain
weh Nov 13, 2023
5ec8c1a
Add alias for postcss plain
weh Nov 13, 2023
53bc3e2
Add alias for spring framework
weh Nov 13, 2023
e3df3ba
Add alias for typo3 plain
weh Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 70 additions & 32 deletions devicon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2364,17 +2364,24 @@
"versions": {
"svg": [
"original",
"original-wordmark",
"plain",
"plain-wordmark"
"original-wordmark"
],
"font": [
"plain",
"plain-wordmark"
"original",
"original-wordmark"
]
},
"color": "#0080FF",
"aliases": []
"aliases": [
{
"base": "original",
"alias": "plain"
},
{
"base": "original-wordmark",
"alias": "plain-wordmark"
}
]
},
{
"name": "discordjs",
Expand Down Expand Up @@ -3374,18 +3381,25 @@
],
"versions": {
"svg": [
"plain",
"original",
"original-wordmark",
"plain-wordmark"
"original-wordmark"
],
"font": [
"plain",
"plain-wordmark"
"original",
"original-wordmark"
]
},
"color": "#64328B",
"aliases": []
"aliases": [
{
"base": "original",
"alias": "plain"
},
{
"base": "original-wordmark",
"alias": "plain-wordmark"
}
]
},
{
"name": "gazebo",
Expand Down Expand Up @@ -5399,7 +5413,7 @@
],
"versions": {
"svg": [
"original",
"original",
"original-wordmark",
"line",
"line-wordmark"
Expand Down Expand Up @@ -6180,16 +6194,20 @@
"svg": [
"original",
"original-wordmark",
"plain",
"plain-wordmark"
],
"font": [
"plain",
"original",
"plain-wordmark"
]
},
"color": "#00618a",
"aliases": []
"aliases": [
{
"base": "original",
"alias": "plain"
}
]
},
{
"name": "nano",
Expand Down Expand Up @@ -6520,16 +6538,20 @@
"svg": [
"original",
"original-wordmark",
"plain",
"plain-wordmark"
],
"font": [
"plain",
"original",
"plain-wordmark"
]
},
"color": "#83CD29",
"aliases": []
"aliases": [
{
"base": "original",
"alias": "plain"
}
]
},
{
"name": "nodemon",
Expand Down Expand Up @@ -7585,16 +7607,20 @@
"svg": [
"original",
"original-wordmark",
"plain",
"plain-wordmark"
],
"font": [
"plain",
"original",
"plain-wordmark"
]
},
"color": "#dd3735",
"aliases": []
"aliases": [
{
"base": "original",
"alias": "plain"
}
]
},
{
"name": "postgresql",
Expand Down Expand Up @@ -9508,22 +9534,30 @@
"springframework"
],
"tags": [
"framework"
"framework",
"java"
],
"versions": {
"svg": [
"original",
"original-wordmark",
"plain",
"plain-wordmark"
"original-wordmark"
],
"font": [
"plain",
"plain-wordmark"
"original",
"original-wordmark"
]
},
"color": "#5FB832",
"aliases": []
"aliases": [
{
"base": "original",
"alias": "plain"
},
{
"base": "original-wordmark",
"alias": "plain-wordmark"
}
]
},
{
"name": "spss",
Expand Down Expand Up @@ -10420,16 +10454,20 @@
"svg": [
"original",
"original-wordmark",
"plain",
"plain-wordmark"
],
"font": [
"plain",
"original",
"plain-wordmark"
]
},
"color": "#f49700",
"aliases": []
"aliases": [
{
"base": "plain",
"alias": "original"
}
]
},
{
"name": "ubuntu",
Expand Down
1 change: 0 additions & 1 deletion icons/digitalocean/digitalocean-plain-wordmark.svg
View file
Open in desktop
Copy link
Member

@canaleal canaleal Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully both plain svgs for digital ocean can be removed, but the original svgs have to be updated to have 1 path and fill color. They also have to be scaled to fit the viewbox.

image

Copy link
Contributor Author

@weh weh Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in #2005

This file was deleted.

1 change: 0 additions & 1 deletion icons/digitalocean/digitalocean-plain.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion icons/gatsby/gatsby-plain-wordmark.svg
View file
Open in desktop
Copy link
Member

@canaleal canaleal Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gatsby-original-wordmark.svg has 2 paths and 2 different fill colors. It unfortunately cant be used for plain-wordmark.

Copy link
Contributor Author

@weh weh Nov 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in #2006

This file was deleted.

1 change: 0 additions & 1 deletion icons/gatsby/gatsby-plain.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion icons/mysql/mysql-plain.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion icons/nodejs/nodejs-plain.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion icons/postcss/postcss-plain.svg
View file
Open in desktop
Copy link
Member

@canaleal canaleal Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the postcss-original.svg has multiple paths with different fill colors. I think this SVG needs to remain, but the paths need to be unified, and the fill color changed to #dd3a0aff.

Copy link
Contributor Author

@weh weh Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in #2012

This file was deleted.

1 change: 0 additions & 1 deletion icons/spring/spring-plain-wordmark.svg
View file
Open in desktop

This file was deleted.

Loading