Skip to content

Conversation

@Snailedlt
Copy link
Collaborator

@Snailedlt Snailedlt commented Nov 12, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

fixes issues with #1977

Link to prove your SVG is correct and up-to-date.

line-wordmark version was recreated using the made-with-unity logo: https://brandfolder.com/s/3v2rb9wqbr9sjbh5gqmmcq
all other versions are modifications of the existing versions in the develop branch.

@Snailedlt Snailedlt changed the base branch from master to develop November 12, 2023 14:20
@Snailedlt Snailedlt changed the title Fix artifacts with unity icons update icon: (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Nov 12, 2023
@Snailedlt Snailedlt requested a review from canaleal November 12, 2023 14:20
@Snailedlt Snailedlt closed this Nov 12, 2023
@Snailedlt Snailedlt reopened this Nov 12, 2023
@Snailedlt
Copy link
Collaborator Author

Previews:
image
image
image
image
image

@Snailedlt Snailedlt changed the title update icon: (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Nov 12, 2023
@Snailedlt Snailedlt closed this Nov 12, 2023
@Snailedlt Snailedlt reopened this Nov 12, 2023
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Nov 12, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one! 💯
Made a tiny adjustment on each icon by removing some unnecessary whitespace characters. 🔧
Thank you for this contribution! 🚀

Copy link

@mahmudunnabikajal mahmudunnabikajal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon looks good!

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. All is good.

@lunatic-fox lunatic-fox merged commit e46a27f into devicons:develop Nov 12, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…k, line, line-wordmark) (devicons#1994)

* fix artifacts for line versions

* resize all versions to fit viewbox

* Remove unnecessary whitespaces

---------

Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants