new icon: Couchbase (original, original-wordmark, plain-wordmark) #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snailedlt
requested changes
Oct 24, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Awesome!
Welcome to devicons, this is a great first PR!
The icon looks great, though I'm wondering if you could also add the wordmark version :)
SAHIL-KUMAR-EE
changed the title
SAHIL-KUMAR-EE
changed the title
Snailedlt
requested changes
Oct 27, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Sorry if my previous suggestions were a bit hard to understand. I hope this is better. If not, let me know :)
File at icons/couchbase/couchbase-plain.svg removed since it is the same icon as couchbase-original.svg without the color.
Removed "plain" in SVG section of "couchbase". Also removed alias for plain-wordmark.svg as it already exists.
SAHIL-KUMAR-EE
changed the title
Snailedlt
reviewed
Oct 28, 2023
Snailedlt
reviewed
Oct 28, 2023
Snailedlt
approved these changes
Oct 28, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
I made some small changes (see the last two commits) to get this PR done. Hope you don't mind :)
Thank you for the contribution! ✔️
Hope to see more! 💯
Snailedlt
requested review from
a team,
ConX,
canaleal,
lunatic-fox and
weh
and removed request for
a team
Snailedlt
added
hacktoberfest-accepted
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
…vicons#1932) * new icon: Couchbase (original) * Added couchbase in devicon.json * Added alias for Couchbase * Added couchbase-original-wordmark * Updated plain and plain-wordwork in devicon.json * Added couchbase-plain.svg * Added couchbase-plain-wordmark.svg * Removed couchbase-plain.svg File at icons/couchbase/couchbase-plain.svg removed since it is the same icon as couchbase-original.svg without the color. * Updated devicon.json Removed "plain" in SVG section of "couchbase". Also removed alias for plain-wordmark.svg as it already exists. * change font from original-wordmark to plain-wordmark * optimize and unify paths for plain-wordmark --------- Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #1931
Link to prove your SVG is correct and up-to-date.
Couchbase Logo