new icon: Pulsar (original, original-wordmark) #1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @weh, the icons and Json looks good, but pulsar is missing from the SVG file names. |
Contributor
Author
|
you are right @canaleal, i fixed the filenames :) |
canaleal
reviewed
Oct 10, 2023
Member
canaleal
left a comment
canaleal
left a comment
There was a problem hiding this comment.
Everything looks good and follows SVG guidelines. Nice.
Snailedlt
requested changes
Oct 21, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Excellent work!
Just suggested some simplification of the svg's. Once the suggestions are accepted it's ready to merge!
weh
added
the
hacktoberfest-accepted
Snailedlt
approved these changes
Oct 22, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
LGTM! ✔️
Thank you for another great contribution! 💯 🙇
Snailedlt
requested changes
Oct 22, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Whoops, went through your PR a little fast.
It looks like there are some new conflicts in devicon.json could you try and fix them?
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
weh
force-pushed
the
feature/1810-add-pulsar-icon
branch
from
c638cc2 to
bd8f91a
Compare
Contributor
Author
|
Rebase is done, should be ok now |
Snailedlt
approved these changes
Oct 24, 2023
Snailedlt
added
the
feature:icon
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* new icon: Pulsar (original, original-wordmark) * Rename files to match conventions * Remove height and with, and replace color Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Remove height and with, and replace color Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> --------- Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes
closes #1810
Link to prove your SVG is correct and up-to-date.
https://pulsar-edit.dev/