Skip to content

Conversation

@canaleal
Copy link
Member

@canaleal canaleal commented Oct 5, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1818

Link to prove your SVG is correct and up-to-date.

The Ory website uses a darker purple for their icon. I went with the light purple as shown in their github documentation.

Main Website: https://www.ory.sh/
Github: https://github.com/ory
Assets: https://github.com/ory/docs/tree/master/src/static/img/logos

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see the only thing missing is unifying the paths for both icons

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

@Snailedlt Snailedlt requested review from a team, ConX and lunatic-fox and removed request for a team October 21, 2023 23:09
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 21, 2023
Copy link
Contributor

@ConX ConX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @canaleal!

@Snailedlt Snailedlt merged commit bb03aa7 into devicons:develop Oct 22, 2023
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…evicons#1885)

* Added ory icon

* Added a new line for each SVG

* Unified ORY paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants