new icon: framework7 (original, original-wordmark) #1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add_framework7
dotarjun
changed the title
dotarjun
changed the title
Gautam25Raj
suggested changes
Jun 3, 2023
|
Maybe we don't need this plain version. Both plain and original have single color. What do you think? 🤔 |
|
agreed |
- Rename icons from "framework-[version].svg" to "framework7-[version].svg". - Remove "style" attribute from `original` version. - Remove trailing comma in `devicon.json`.
lunatic-fox
changed the title
lunatic-fox
previously approved these changes
Jun 4, 2023
dotarjun
commented
Jun 4, 2023
Same for me. 😆 |
Gautam25Raj
previously approved these changes
Jun 4, 2023
Panquesito7
added
the
feature:icon
Panquesito7
reviewed
Jun 4, 2023
|
thank you, guys! |
Gautam25Raj
approved these changes
Jun 5, 2023
lunatic-fox
approved these changes
Jun 8, 2023
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* add framework7 original and plain icons * update devicons.json with framework7 * remove color from plain svg * resize to 128 * try to resize again * remove grid and fix svg * optimise svgs * add original and plain wordmark versions * rename according to the naming convention * add wordmark versions * remove width/height and use viewBox instead * resize and optimise svg * resize and optimise original wordmark svg * add plain wordmark to font array * remove plain versions * Add aliases and remove plain, plain-wordmark versions * Add newline and some fixes: - Rename icons from "framework-[version].svg" to "framework7-[version].svg". - Remove "style" attribute from `original` version. - Remove trailing comma in `devicon.json`. * add open-source under tags --------- Co-authored-by: Josélio Júnior <[email protected]> Co-authored-by: David Leal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes NONE
#1776
Link to prove your SVG is correct and up-to-date.
https://framework7.io/